Skip to content

feat: make use_rep accept anndata.acc - #4315

Merged
flying-sheep merged 5 commits into
mainfrom
use-rep-future
Aug 27, 2026
Merged

feat: make use_rep accept anndata.acc#4315
flying-sheep merged 5 commits into
mainfrom
use-rep-future

Conversation

@flying-sheep

Copy link
Copy Markdown
Member

@flying-sheep flying-sheep added this to the 1.13.0 milestone Aug 21, 2026
Comment thread src/scanpy/get/get.py Outdated
Comment thread src/scanpy/get/get.py Outdated
Comment thread src/scanpy/neighbors/_doc.py
@flying-sheep
flying-sheep requested a review from ilan-gold August 21, 2026 15:20
@flying-sheep flying-sheep mentioned this pull request Aug 21, 2026
@flying-sheep flying-sheep changed the title feat: use_rep accepts anndata.acc feat: make use_rep accept anndata.acc Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.37209% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.14%. Comparing base (e6269f5) to head (abb365f).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/tools/_ingest.py 61.53% 5 Missing ⚠️
src/scanpy/tools/_utils.py 88.46% 3 Missing ⚠️
src/scanpy/get/get.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
+ Coverage   80.08%   80.14%   +0.06%     
==========================================
  Files         133      133              
  Lines       13424    13478      +54     
==========================================
+ Hits        10750    10802      +52     
- Misses       2674     2676       +2     
Flag Coverage Δ
hatch-test.low-vers 77.92% <63.95%> (-0.09%) ⬇️
hatch-test.pre 80.01% <88.37%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/neighbors/__init__.py 81.54% <100.00%> (+0.05%) ⬆️
src/scanpy/neighbors/_doc.py 100.00% <100.00%> (ø)
src/scanpy/neighbors/_types.py 100.00% <100.00%> (ø)
src/scanpy/tools/_dendrogram.py 82.97% <100.00%> (+0.37%) ⬆️
src/scanpy/tools/_tsne.py 75.55% <100.00%> (+0.55%) ⬆️
src/scanpy/tools/_umap.py 86.53% <100.00%> (+0.26%) ⬆️
src/scanpy/get/get.py 89.88% <94.11%> (+0.42%) ⬆️
src/scanpy/tools/_utils.py 90.24% <88.46%> (+3.28%) ⬆️
src/scanpy/tools/_ingest.py 80.93% <61.53%> (-0.10%) ⬇️

Comment thread tests/test_neighbors.py
Comment thread src/scanpy/tools/_utils.py
Comment thread tests/test_neighbors.py
@flying-sheep
flying-sheep enabled auto-merge (squash) August 27, 2026 15:05
@flying-sheep
flying-sheep merged commit 84b6b1b into main Aug 27, 2026
14 checks passed
@flying-sheep
flying-sheep deleted the use-rep-future branch August 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have use_rep accept anndata.acc acessors

2 participants