Skip to content

Set main window name to Biscotti - #95

Closed
scosman wants to merge 1 commit into
mainfrom
window_name
Closed

scosman wants to merge 1 commit into
mainfrom
window_name

Conversation

@scosman

@scosman scosman commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Set the SwiftUI Window scene title from "" to "Biscotti" so other apps (Accessibility clients, AppleScript, window managers) can identify the window
  • Removed the window?.title = "" lines from WindowTitleHider that were actively blanking the programmatic name
  • titleVisibility = .hidden remains — the title bar appearance is unchanged

Test plan

  • Verify title bar still shows no text (visual appearance unchanged)
  • Verify via Accessibility Inspector or AppleScript that the window reports name "Biscotti"

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • The app window no longer displays its title text, creating a cleaner title bar. The window retains the title “Biscotti” for accessibility and identification by other apps.

The Window scene title was empty and WindowTitleHider actively blanked
window.title. Other apps (Accessibility clients, AppleScript, window
managers) could not identify the window. Set the scene title to
"Biscotti" and stop blanking window.title — titleVisibility stays
.hidden so the title bar appearance is unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a50b2b65-5297-4595-9fcf-183582272eea

📥 Commits

Reviewing files that changed from the base of the PR and between d80e69c and 1b60cff.

📒 Files selected for processing (1)
  • App/Sources/BiscottiApp.swift

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The main window now has the programmatic title “Biscotti”. WindowTitleHider hides the displayed title text without clearing the programmatic title.

Changes

Window title handling

Layer / File(s) Summary
Set and hide the window title
App/Sources/BiscottiApp.swift
The main window title changes from an empty string to “Biscotti”. WindowTitleHider hides the displayed title in both lifecycle methods without clearing the programmatic title. Its documentation describes the title’s availability to other apps through Accessibility and AppleScript.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 1b60c

The window retains “Biscotti” while hiding its displayed title. Accessibility and AppleScript exposure was not confirmed, but no failure is established; verify those clients on macOS before relying on that benefit.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 1b60c

The window gains a fixed application name rather than exposing user content or accepting new commands. No material security risk was identified in this change. Accessibility and AppleScript behavior still require runtime verification.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The changed exposure is main-window identification by consumers able to inspect its metadata. Removing title blanking changes observability, but the changed operations do not grant command execution, data access, or additional privileges.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: setting the main window name to "Biscotti".
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scosman

scosman commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

closing. Name doesn't look good in title bar

@scosman scosman closed this Oct 1, 2026
@scosman
scosman deleted the window_name branch October 1, 2026 01:58
@scosman
scosman restored the window_name branch October 1, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant