Skip to content

Fix type-checker timeout in AppShellViewModelTests #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scosman merged 2 commits into from
Sep 2, 2026
Merged

Fix type-checker timeout in AppShellViewModelTests #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
098f7bd
Fix type-checker timeout in AppShellViewModelTests
noxan Sep 1, 2026
7bc5016
Hoist type-checker-heavy offsets in HomeViewModelTests EKEventDTO lit…
scosman Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions Packages/BiscottiKit/Tests/AppShellUITests/AppShellViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,21 +709,17 @@ struct AppShellUpcomingCapTests {
@MainActor
func upcomingEventsCappedAt6() async throws {
let now = Date()
let dtos = (0 ..< 9).map { idx in
EKEventDTO(
let dtos = (0 ..< 9).map { idx -> EKEventDTO in
let start: TimeInterval = Double(idx + 1) * 600
let end: TimeInterval = start + 3600
return EKEventDTO(
eventIdentifier: "ev-cap-\(idx)",
calendarItemIdentifier: "ci-cap-\(idx)",
calendarItemExternalIdentifier: "ext-cap-\(idx)",
occurrenceDate: now.addingTimeInterval(
Double(idx + 1) * 600
),
occurrenceDate: now.addingTimeInterval(start),
title: "Cap Event \(idx)",
startDate: now.addingTimeInterval(
Double(idx + 1) * 600
),
endDate: now.addingTimeInterval(
Double(idx + 1) * 600 + 3600
),
startDate: now.addingTimeInterval(start),
endDate: now.addingTimeInterval(end),
isAllDay: false,
location: "https://zoom.us/j/cap\(idx)",
url: nil,
Expand Down
10 changes: 6 additions & 4 deletions Packages/BiscottiKit/Tests/HomeUITests/HomeViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,17 @@ struct HomeViewModelStateTests {
@MainActor
func homeShowsUpcomingPreview() async throws {
let now = Date()
let dtos = (0 ..< 8).map { idx in
EKEventDTO(
let dtos = (0 ..< 8).map { idx -> EKEventDTO in
let start: TimeInterval = Double(idx + 1) * 600
let end: TimeInterval = start + 3600
return EKEventDTO(
eventIdentifier: "ev-\(idx)",
calendarItemIdentifier: "ci-\(idx)",
calendarItemExternalIdentifier: "ext-\(idx)",
occurrenceDate: now,
title: "Event \(idx)",
startDate: now.addingTimeInterval(Double(idx + 1) * 600),
endDate: now.addingTimeInterval(Double(idx + 1) * 600 + 3600),
startDate: now.addingTimeInterval(start),
endDate: now.addingTimeInterval(end),
isAllDay: false,
location: "https://zoom.us/j/\(idx)",
url: nil,
Expand Down
Loading