parse scaladoc wiki links with a shared backtick/nesting-aware parser - #8676
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds shared Scaladoc wiki-link parsing for target/title extraction and offset lookup, applies it to rendering and definition navigation, handles quoted ChangesScaladoc WikiLink handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ScaladocDefinitionProvider
participant WikiLink
participant ScalaDocLink
ScaladocDefinitionProvider->>WikiLink: atOffset(text, offset)
WikiLink-->>ScaladocDefinitionProvider: target
ScaladocDefinitionProvider->>ScalaDocLink: create definition link
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tgodzik
pushed a commit
to tgodzik/metals
that referenced
this pull request
Jul 30, 2026
…scalameta#8676) First part of scalameta#8658, paritally fixing scalameta#3383 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Improved Scaladoc and Javadoc link parsing, including links with custom titles, nested brackets, signatures, and backticked names. * Fixed navigation so links resolve to their actual target symbols rather than displayed titles. * Correctly renders quoted `@see` text as plain text instead of a link. * **Tests** * Added coverage for complex link formats, offset detection, and definition navigation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit cb485be)
tgodzik
pushed a commit
to tgodzik/metals
that referenced
this pull request
Jul 31, 2026
…scalameta#8676) First part of scalameta#8658, paritally fixing scalameta#3383 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Improved Scaladoc and Javadoc link parsing, including links with custom titles, nested brackets, signatures, and backticked names. * Fixed navigation so links resolve to their actual target symbols rather than displayed titles. * Correctly renders quoted `@see` text as plain text instead of a link. * **Tests** * Added coverage for complex link formats, offset detection, and definition navigation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit cb485be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of #8658, paritally fixing #3383
Summary by CodeRabbit
Bug Fixes
@seetext as plain text instead of a link.Tests