Replace Regex with lazy-regex - #7
Open
ZedThree wants to merge 1 commit into
Open
Conversation
The uses of `Regex` in `formatter.rs` were not being constructed lazily or with `OnceLock`, meaning that the cost of constructing them was being paid every single time the containing function was called. Constructing them lazily gives a significant performance enhancement (~15x in some cases). Using the [`lazy-regex`](https://docs.rs/lazy-regex/latest/lazy_regex/) crate simplifies the construction of lazy+static regexes, and has some other benefits (compile time checking, for instance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uses of
Regexinformatter.rswere not being constructed lazily or withOnceLock, meaning that the cost of constructing them was being paid every single time the containing function was called.Constructing them lazily gives a significant performance enhancement (~15x in some cases).
Using the
lazy-regexcrate simplifies the construction of lazy+static regexes, and has some other benefits (compile time checking, for instance).Improvement is most noticeable on large files (>1k lines), where running
ffmt --checkcan go from ~800ms to ~50ms.