Fix table round-tripping. - #486
Open
luciansmith wants to merge 3 commits into
Open
Conversation
The table from Biomodel 197 was being mangled both going and coming; this fixes both. We should also push them upstream to the source libraries, too.
Pulled in the latest changes from maddy, and added two of my PRs that have not yet been accepted, but are needed for libsbml.
Member
|
@luciansmith that looks great, if anything it is unfortunate, that the changes from: 92a3f5c are undone with the commit. Those were needed last nov to compile. |
Member
Author
|
I can certainly add them back in, but it's weird that everything seems to be passing/compiling without the changes? Did the failing compiler change, or something? |
Member
it failed on another system, not the one we were testing under. Anyways it would be great to have it in, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table from Biomodel 197 was being mangled both going and coming; this fixes both. We should also push them upstream to the source libraries, too.