[hermes] feat(log-router): add kafkaForwarding configuration - #12707
Open
wiltongarcia wants to merge 1 commit into
Open
[hermes] feat(log-router): add kafkaForwarding configuration#12707wiltongarcia wants to merge 1 commit into
wiltongarcia wants to merge 1 commit into
Conversation
Adds logRouter.kafkaForwarding (enabled, brokers, topic, tls) to values.yaml (disabled by default) and a conditional block in the log-router ConfigMap template that injects the three LOG_ROUTER_KAFKA_FORWARDING_* env vars when enabled. No Secret or StatefulSet changes needed — TLS with a public CA requires no mounted cert files.
wiltongarcia
requested review from
Kuckkuck,
LeoZhangZXZ,
ashifnihalb,
ibakshay,
joluc,
notandy,
notque,
olandr,
richardtief,
timojohlo,
trouaux and
viennaa
as code owners
September 1, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logRouter.kafkaForwardingblock tovalues.yaml(disabled by default):enabled,brokers,topic,tlslog-router-configmap.yamlthat injectsLOG_ROUTER_KAFKA_FORWARDING_BROKERS,LOG_ROUTER_KAFKA_FORWARDING_TOPIC, andLOG_ROUTER_KAFKA_FORWARDING_TLSwhenkafkaForwarding.enabled=truerequiredguards so a deployment withenabled=truebut missingbrokers/topicfails at render timeNo other template changes needed
TLS with a public CA (fortlogs broker) requires no mounted Secret files — the env var
LOG_ROUTER_KAFKA_FORWARDING_TLS: "true"instructs log-router to use system root CAs.Related