Skip to content

[cinder] Pass terminationGracePeriodSeconds to CinderNetappConfig CR for KVM pods - #12686

Merged
hemna merged 1 commit into
masterfrom
cinder/kvm-termination-grace-period
Aug 27, 2026
Merged

[cinder] Pass terminationGracePeriodSeconds to CinderNetappConfig CR for KVM pods#12686
hemna merged 1 commit into
masterfrom
cinder/kvm-termination-grace-period

Conversation

@hemna

@hemna hemna commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The kvm-cinder-netapp-operator CRD already supports the terminationgraceperiodseconds field (verified live in qa-de-1), but the Helm chart was not populating it. KVM cinder-volume pods were getting the Kubernetes default of 30s, while VMware volume and backup pods get 900s.

Problem

Measured in qa-de-1:

Pod type terminationGracePeriodSeconds
VMware volume (cinder-volume-vmware-vc-*) 900
VMware backup (cinder-volume-backup-vmware-vc-*) 900
KVM volume (cinder-volume-kvm-*) 30

With 30s, any in-flight KVM volume operation taking longer than 30 seconds (e.g., volume create from image, migration) will be SIGKILLed by Kubernetes during pod shutdown.

Fix

One line added to cindernetappconfig.yaml to pass pod.terminationGracePeriodSeconds.volume into the CinderNetappConfig CR:

terminationgraceperiodseconds: {{ .Values.pod.terminationGracePeriodSeconds.volume }}

The value defaults to 30 in values.yaml and is overridden to 900 per region in secrets (e.g., qa-de-1/values/cinder.yaml already sets pod.terminationGracePeriodSeconds.volume: 900).

No secrets change needed

The secrets already set volume: 900 — the value just wasn't being passed to the operator CR.

Required for

Graceful shutdown feature: sapcc/cinder#358

Related

The kvm-cinder-netapp-operator CRD already supports the
terminationgraceperiodseconds field, but the Helm chart was not
populating it. KVM cinder-volume pods were getting the Kubernetes
default of 30s, while VMware volume and backup pods get 900s
(set via secrets).

This causes KVM pods to be SIGKILLed after 30s during shutdown,
killing any in-flight operation that takes longer (e.g., volume
create from image, migration). Required for the graceful shutdown
feature (sapcc/cinder#358).

The value comes from pod.terminationGracePeriodSeconds.volume,
which defaults to 30 in values.yaml and is overridden to 900 per
region in secrets (e.g., qa-de-1/values/cinder.yaml).
@hemna
hemna merged commit c47e348 into master Aug 27, 2026
3 checks passed
@hemna
hemna deleted the cinder/kvm-termination-grace-period branch August 27, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants