[cinder] Pass terminationGracePeriodSeconds to CinderNetappConfig CR for KVM pods - #12686
Merged
Conversation
The kvm-cinder-netapp-operator CRD already supports the terminationgraceperiodseconds field, but the Helm chart was not populating it. KVM cinder-volume pods were getting the Kubernetes default of 30s, while VMware volume and backup pods get 900s (set via secrets). This causes KVM pods to be SIGKILLed after 30s during shutdown, killing any in-flight operation that takes longer (e.g., volume create from image, migration). Required for the graceful shutdown feature (sapcc/cinder#358). The value comes from pod.terminationGracePeriodSeconds.volume, which defaults to 30 in values.yaml and is overridden to 900 per region in secrets (e.g., qa-de-1/values/cinder.yaml).
hemna
requested review from
Scsabiii,
fwiesel,
jagoleni,
joker-at-work and
sumitarora2786
as code owners
August 27, 2026 15:01
BzzyBriel
approved these changes
Aug 27, 2026
Scsabiii
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
kvm-cinder-netapp-operatorCRD already supports theterminationgraceperiodsecondsfield (verified live in qa-de-1), but the Helm chart was not populating it. KVM cinder-volume pods were getting the Kubernetes default of 30s, while VMware volume and backup pods get 900s.Problem
Measured in qa-de-1:
cinder-volume-vmware-vc-*)cinder-volume-backup-vmware-vc-*)cinder-volume-kvm-*)With 30s, any in-flight KVM volume operation taking longer than 30 seconds (e.g., volume create from image, migration) will be SIGKILLed by Kubernetes during pod shutdown.
Fix
One line added to
cindernetappconfig.yamlto passpod.terminationGracePeriodSeconds.volumeinto theCinderNetappConfigCR:The value defaults to 30 in
values.yamland is overridden to 900 per region in secrets (e.g.,qa-de-1/values/cinder.yamlalready setspod.terminationGracePeriodSeconds.volume: 900).No secrets change needed
The secrets already set
volume: 900— the value just wasn't being passed to the operator CR.Required for
Graceful shutdown feature: sapcc/cinder#358
Related
--single-childto dumb-init for backup pods (same graceful shutdown prerequisite)dumb-init --single-childfor VMware volume pods