update to make the deviceClass configurable for standrad pool placements - #12568
Merged
sumitarora2786 merged 4 commits intoSep 8, 2026
Merged
Conversation
venkata-avinash-a
requested review from
a team and
sumitarora2786
as code owners
August 13, 2026 22:45
venkata-avinash-a
marked this pull request as draft
August 13, 2026 22:47
venkata-avinash-a
marked this pull request as ready for review
September 8, 2026 22:22
sumitarora2786
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
deviceClassconfigurable forstandardPlacementspoolsReplace the hardcoded
nvme-standarddevice class in the standardPlacements block with{{ $target.deviceClass | default "nvme-standard" }}, allowing per-region override via values while keeping existing clusters unaffected.