fix(netapp-harvest-exporter): guard AbsentNetAppSnapmirrorLabelsMaia against replication-sink regions - #12547
Open
chuan137 wants to merge 1 commit into
Open
fix(netapp-harvest-exporter): guard AbsentNetAppSnapmirrorLabelsMaia against replication-sink regions#12547chuan137 wants to merge 1 commit into
chuan137 wants to merge 1 commit into
Conversation
…against replication-sink regions Regions that serve only as snapmirror destinations (e.g. na-us-3) have no local rw source volumes, so netapp_snapmirror_labels:local is always empty and :maia is always absent. The alert was firing as a false positive. Guard the alert with `count(netapp_snapmirror_labels:local) > 0` so it only fires in regions that actually have snapmirror source relationships to track.
chuan137
requested review from
Carthaca,
RockSolidScripts,
crenduchinta88,
hvr999,
kpawar-sap and
sumitarora2786
as code owners
August 11, 2026 10:47
Carthaca
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AbsentNetAppSnapmirrorLabelsMaiawas firing as a false positive in regions that act as pure replication sinks (e.g.na-us-3).In these regions all NetApp volumes scraped locally are
volume_type=dp(replica destinations). The:enhancedrecording rule joins onvolume_type="rw"source volumes, which don't exist here, sonetapp_snapmirror_labels:localis always empty and:maiais always absent — by design, not due to a real problem.Verified across all production regions:
:localcountFix
Guard the alert with
count(netapp_snapmirror_labels:local) > 0— only fire when the region has local snapmirror source relationships to track.Test plan
:maiagoes absent (e.g. by checking alert history in eu-de-1)