[DO NOT MERGE] feat(runtime): enable scratch runtime via in-binary firewall lifecycle - #79
Open
rkschamer wants to merge 11 commits into
Open
[DO NOT MERGE] feat(runtime): enable scratch runtime via in-binary firewall lifecycle#79rkschamer wants to merge 11 commits into
rkschamer wants to merge 11 commits into
Conversation
This was referenced Aug 24, 2026
rkschamer
force-pushed
the
d053727/runtime-image-from-scratch
branch
3 times, most recently
from
August 25, 2026 14:56
30bc7fb to
b1bde83
Compare
rkschamer
marked this pull request as draft
August 26, 2026 13:32
rkschamer
changed the title
Contributor
Author
|
Do not merge this PR, before we verified in QA that this version is working as expected in QA. We use the image produced by the PR pipeline to deploy this version to QA. |
Because of reported vulnerbilities
rkschamer
marked this pull request as ready for review
August 31, 2026 07:37
Builds and pushes PR images tagged as ghcr.io/sapcc/go-pmtud:pr-<number> to allow testing container images before merge. This file is not managed by go-makefile-maker and will not be overwritten.
* feat(ci): add per-commit SHA tag to PR container image The PR workflow only produces a mutable pr-<number> tag which gets overwritten on every push. Keppel mirror caches won't re-pull the same tag, making it impossible to test updated PR builds. Add an immutable pr-<number>-<sha> tag alongside the existing one so each push produces a unique image reference usable for testing. * fix docker image --------- Co-authored-by: Rene Kschamer <rene.kschamer@sap.com>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables FROM scratch runtime image by moving NFLOG rule and rp_filter sysctl management from shell scripts (init container + preStop hook) into the go-pmtud binary. Companion helm-charts PR removes the init container and preStop hook.
After merge, sapcc/helm-charts#12636 needs to be merged as well.