docs: fix org-less issue links, rx3 artifact drift, dead badges, and stale demo paths - #340
Open
ZayanKhan-12 wants to merge 4 commits into
Open
Conversation
github.com/reactive-grpc/issues is missing the salesforce org segment and 404s; the in-page anchors used underscores, but GitHub slugs the 'Creating a Pull Request' heading with hyphens. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The rx3grpc/rx3grpc-stub READMEs pointed badges, dependency artifactIds, and the protoc plugin mainClass at the old rxgrpc artifacts: the published artifacts are rx3grpc/rx3grpc-stub and the generator class is com.salesforce.rx3grpc.Rx3GrpcGenerator (the only generator in the module). Also replaces the maven-badges.herokuapp.com badge images, which return 404 since the Heroku free tier shutdown, with shields.io equivalents (verified 200). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maven-badges.herokuapp.com has returned 404 since the Heroku free-tier shutdown, so every module README's Maven Central badge is broken. Use shields.io badges (verified 200) linking to central.sonatype.com, keeping each module's own artifact id. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The demo moved to demos/reactive-grpc-chat/reactor-chat-kotlin/, so the documented -pl module paths and jar path no longer exist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the contribution! Before we can merge this, we need @zk-khan to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits, all documentation:
github.com/reactive-grpc/issues) are missing thesalesforce/org segment and 404; the in-page anchors used#creating_a_pull_request, but GitHub slugs the "Creating a Pull Request" heading with hyphens.<artifactId>rxgrpc</artifactId>/rxgrpc-stub(published artifacts arerx3grpc/rx3grpc-stub), protoc pluginmainClasscom.salesforce.rx3grpc.RxGrpcGenerator(the class isRx3GrpcGenerator— the only generator in the module), and badges pointing at the rxgrpc artifacts.maven-badges.herokuapp.combadge images return 404 since the Heroku free-tier shutdown; replaced with shields.io Maven Central badges (verified 200) linking to central.sonatype.com, keeping each module's own artifact id.demos/ReactorChat-Kotlin/...module paths; the demo lives atdemos/reactive-grpc-chat/reactor-chat-kotlin/ReactorChat-{Server,Client}-Kt.Verification: class/artifact names checked against the tree and Maven Central (rx3grpc/rx3grpc-stub badges resolve; old badge URLs curl 404); full
mvn testpasses locally (BUILD SUCCESS, 369 tests, 0 failures; JDK 21 toolchain, macOS arm64).Prepared with AI assistance (Claude); every claim mechanically verified as described.