Skip to content

Bound the overlap-offset window scan so an unresponsive app can't freeze the UI #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MyronKoch wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Bound the overlap-offset window scan so an unresponsive app can't freeze the UI #1810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Rectangle/WindowManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ class WindowManager {
// overlap scan, so skip the offset rather than cascade against itself.
guard let windowId else { return rect }

// This scan enumerates every window over the accessibility API on the
// main thread. A hung or (under heavy system load) sluggish app can
// otherwise block that for the full default AX timeout - seconds -
// freezing the UI on each window move. Cap messaging for the scan and
// restore the default immediately after; an app that can't answer in
// time is simply skipped (no offset), which is harmless.
AXUIElementSetMessagingTimeout(AXUIElement.systemWide, 0.25)
defer { AXUIElementSetMessagingTimeout(AXUIElement.systemWide, 0) }

let screenFrameAX = screen.adjustedVisibleFrame().screenFlipped
let tolerance: CGFloat = 4
let maxCascade = min(5, max(1, Defaults.cyclingOverlapMaxCascade.value))
Expand Down
Loading