Reapply shortcuts when restoring current defaults - #1806
Open
arhxam wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for contributing! All of these PRs look good, I'll just spend some time manually testing prior to merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1119.
Previously, selecting the already-active scheme removed persisted overrides but skipped the
changeDefaultsnotification. The shortcut binder therefore kept stale or conflicting bindings until Rectangle restarted.Verification
ShortcutDefaultsRestoreTests: 2/2 passing for same-scheme and changed-scheme resetsRectangleTests: 207 tests run; the same 22 pre-existing assertions fail as onmain, confined toActiveSideSplitRatiosCooperativeTests,CooperativeCornerResizeTests, andHalfSplitCornerCalculationTestsgit diff --check origin/main...HEADAI assistance
AI tooling assisted with investigation, implementation, and test generation. The final diff passed independent specification and code-quality reviews and was verified locally.