Skip to content

Clear omitted shortcuts when importing config - #1805

Open
arhxam wants to merge 2 commits into
rxhanson:mainfrom
arhxam:codex/authoritative-shortcut-import
Open

Clear omitted shortcuts when importing config#1805
arhxam wants to merge 2 commits into
rxhanson:mainfrom
arhxam:codex/authoritative-shortcut-import

Conversation

@arhxam

@arhxam arhxam commented Aug 7, 2026

Copy link
Copy Markdown

Summary

  • treat an imported shortcut map as the complete desired shortcut state
  • remove existing active and Todo-mode shortcuts when their keys are omitted
  • clear invalid negative-key-code entries instead of retaining stale bindings
  • preserve canonical-name precedence and legacy alias fallback

Fixes #1346.

This also prevents an imported shortcut from silently conflicting with an old binding that was intentionally absent from the exported configuration.

Verification

  • ConfigImportTests: 5/5 passing (omitted active, omitted Todo, valid active, alias fallback, invalid active)
  • full RectangleTests: 210 tests run; the same 22 pre-existing assertions fail as on main, confined to ActiveSideSplitRatiosCooperativeTests, CooperativeCornerResizeTests, and HalfSplitCornerCalculationTests
  • git diff --check origin/main...HEAD

AI assistance

AI tooling assisted with investigation, implementation, and test generation. The final diff passed independent specification and code-quality reviews and was verified locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Import settings" does not clear out shortcut keys that doesn't exist in the imported config.

1 participant