Release 4.0.1 - #72
Merged
Merged
Conversation
Add ScrollViewWrapper typedef and optional scrollViewWrapper parameter to InViewNotifierList and InViewNotifierCustomScrollView. This allows users to wrap the internal scroll view with pull-to-refresh or other widgets without exposing InViewNotifier directly (addresses #47, #15, #14, #21). Also adds a pull-to-refresh example tab demonstrating usage with both Flutter's RefreshIndicator and the easy_refresh package.
The scrollViewWrapper feature and pull-to-refresh example were added in the code but not reflected in the user-facing docs. Add the property to the README Properties section and the CHANGELOG 4.0.1 entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dart analyze --fatal-infos fails on Flutter stable newer than v3.41.0-0.0.pre, where ListView/CustomScrollView cacheExtent is deprecated in favour of scrollCacheExtent. scrollCacheExtent does not exist on the package's minimum supported Flutter (>=3.10.0), so switching is not an option. Suppress the deprecation at the two call sites instead, keeping cacheExtent working across the full supported range. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 92.91% 93.12% +0.21%
==========================================
Files 5 5
Lines 127 131 +4
==========================================
+ Hits 118 122 +4
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add an InViewNotifierCustomScrollView + scrollViewWrapper test. This combination was previously untested (only the InViewNotifierList wrapper path had coverage), leaving _applyWrapper uncovered and failing Codecov's patch check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4.0.1 is already published on pub.dev, and scrollViewWrapper is a new feature added after it, so this release takes the next minor version. Moved scrollViewWrapper and the pull-to-refresh example into a new [4.1.0] changelog entry, since they did not ship in 4.0.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 4.0.1
This PR ships version 4.0.1 of
inview_notifier_list.✨ Features
scrollViewWrapper— a new optional callback that wraps the internalScrollViewwith an additional widget (e.g.RefreshIndicator,EasyRefresh,SmartRefresher, or a shimmer wrapper) while keeping in-view detection fully working. Available on bothInViewNotifierListandInViewNotifierCustomScrollView.ListView.builderproperties (cacheExtent,itemExtent,prototypeItem,findChildIndexCallback,addRepaintBoundaries,addSemanticIndexes,semanticChildCount,dragStartBehavior,keyboardDismissBehavior,restorationId,clipBehavior) and the remainingCustomScrollViewproperties (cacheExtent,scrollBehavior,semanticChildCount,dragStartBehavior,keyboardDismissBehavior,restorationId,clipBehavior). (Please add cacheExtent to InViewNotifierList #43, Support cacheExtent prop of CustomScrollView #36)🐛 Fixes
deltaBottomusingsize.heightinstead ofsize.widthfor horizontal scroll lists, which caused incorrect in-view detection. ([Bug] deltaBottom is not calculated correctly in horizontal view #35, condition in horizontal mode #40 — fix identified by @AlexanderFarkas in Fixed deltaBottom for horizontally scrolled lists #37)📱 Example App
scrollViewWrapperwithRefreshIndicatorandEasyRefresh.📝 Docs
scrollViewWrapperin the README Properties section and the CHANGELOG.✅ Quality gates
dart format --set-exit-if-changed .— clean (17 files, 0 changed)dart analyze --fatal-infos— no issuesflutter test— 28 passed