feat: count unreadable source files during backup - #561
Merged
aawsome merged 4 commits intoSep 5, 2026
Conversation
Track scan and archival errors instead of silently ignoring them, and expose the count on SnapshotSummary so callers can return restic exit code 3 for incomplete snapshots.
Contributor
Author
|
Companion CLI PR: rustic-rs/rustic#1908 |
aawsome
reviewed
Sep 4, 2026
Pass source paths as Option through Progress::error instead of empty strings. Persist SnapshotSummary.error_count when it is non-zero. Drop the chmod restore in the tempdir test; unlink only needs directory permissions.
aawsome
changed the title
aawsome
enabled auto-merge
September 5, 2026 21:55
aawsome
approved these changes
Sep 5, 2026
aawsome
left a comment
aawsome
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks a lot @BradKollmyer
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progress::error(scan/archival)SnapshotSummary.error_countfor the just-completed backupWhy
restic returns exit code 3 when some source files cannot be read, and still creates a snapshot of the remaining files. rustic currently ignores those errors and exits 0, so automation cannot detect incomplete backups.
Validation
cargo test --test integration test_backup_unreadable_file_sets_error_count(unix; chmod 000 file)cargo fmt --allA companion rustic CLI PR will use
error_countto exit 3 and emit restic-compatible JSONerror/exit_errormessages.