perf: enable mimalloc in release and ARMv8 AES on aarch64 - #1911
Open
BradKollmyer wants to merge 2 commits into
Open
perf: enable mimalloc in release and ARMv8 AES on aarch64#1911BradKollmyer wants to merge 2 commits into
BradKollmyer wants to merge 2 commits into
Conversation
Warm-cache prune on musl spent a lot of time in libc malloc. mimalloc cut reading index from ~1:36 to 0:19 and finding used blobs from 12:44 to 10:34 versus musl malloc; tikv-jemallocator was slower than mimalloc on the tree walk.
Without --cfg aes_armv8 Darwin prune used software AES and spent ~9s extra in finding used blobs versus rustic dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of rustic-rs/rustic_core#564.
CLI side of the prune warm-cache speedup:
--features release.--cfg aes_armv8 --cfg polyval_armv8for aarch64 Apple/Linux targets so AES-GCM uses ARMv8 crypto instead ofaes::soft.rustic_core/.cargo/config.tomlalready has those AES flags, but they do not apply when the workspace is this CLI. Without them, Darwin prune used-blobs stays on software AES and does not reach the 0:16 number in #564.