winit-x11: don't classify VM tablet pointers as pens - #4657
Open
maurerdietmar wants to merge 1 commit into
Open
Conversation
Device::new marks any pointer whose valuator class carries Abs X/Y labels as DeviceType::Pen, and the XI_Motion/XI_ButtonPress/scroll handlers drop events from every non-mouse source device. Emulated pointing devices in virtual machines (the QEMU/VMware/VirtualBox USB tablets, and any desktop accessed through SPICE or similar VDI viewers) expose absolute X/Y axes without pressure or tilt, so all their motion and button input silently disappears: a winit 0.31 application inside a VM console has a dead mouse. winit 0.30, which had no device classification, handles these devices fine. Classify a device as pen or eraser only when it has pressure or tilt axes, which identify actual stylus hardware; bare absolute X/Y is how every emulated tablet reports and behaves like a mouse. Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device::new marks any pointer whose valuator class carries Abs X/Y labels as DeviceType::Pen, and the XI_Motion/XI_ButtonPress/scroll handlers drop events from every non-mouse source device. Emulated pointing devices in virtual machines (the QEMU/VMware/VirtualBox USB tablets, and any desktop accessed through SPICE or similar VDI viewers) expose absolute X/Y axes without pressure or tilt, so all their motion and button input silently disappears: a winit 0.31 application inside a VM console has a dead mouse. winit 0.30, which had no device classification, handles these devices fine.
Classify a device as pen or eraser only when it has pressure or tilt axes, which identify actual stylus hardware; bare absolute X/Y is how every emulated tablet reports and behaves like a mouse.