Popup anchor system refinement - #4645
Closed
Murmele wants to merge 67 commits into
Closed
Conversation
Reason: Because a normal window can have a parent window as well, like a Dialog
Reason: otherwise the child surface is anchored to the center
Reason: otherwise the height of the client side decoration is not considered and therefore the location is shifted
Reason: There are multiple pointers to the smithay popup. Once in state.windows and one time in the popup object it self. Just dropping the popup object releases only one pointer but we have to notify the state to release also the other
…he position Reason: Much easier in the resize handle
Reason: we have to call resize to initialize the viewport to map to correct window size
Reason: So it is clear which kind of position it is
Reason: On wayland popups don't get automatically keyboard grab. So request on creation
Reason: Because wayland or the event loop could destroy the popup and therefore it is anymore available
Reason: Otherwise it will not be dropped
Otherwise the popup stays in the window_requests of the event_loop
Reason: Because it exists only for wayland
Reason: the positioner does not allow zero size then we get a protocol error
Murmele
marked this pull request as ready for review
July 27, 2026 14:21
Murmele
marked this pull request as draft
July 27, 2026 14:21
Contributor
Author
|
Closed in favour of #4646 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersTested on:
X11Does not support popups