macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius. - #4632
Open
pszsh wants to merge 1 commit into
Open
macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius.#4632pszsh wants to merge 1 commit into
pszsh wants to merge 1 commit into
Conversation
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
July 17, 2026 07:06
3ac18e6 to
18d2a46
Compare
Author
Yeah, I mean I could make a choice here, but I don't know if I'd make the one you would. It's really up to y'all. Please let me know if I'm just being a nuisance, I'm just trying to help but if the way I'm going about things is just wrong or fundamentally missing some larger point that I am not seeing for whatever reason, and I might as well not bother... I'd like to know that so that I can stop wasting everyone's time. I value your time, I am only trying to save you some. One way or another I would appreciate any feedback, to know if It's worth it to keep trying to make this pull request. Thanks, Jess |
3 tasks
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
July 28, 2026 18:09
61398cf to
78d2b13
Compare
Author
|
Cool beans. Hope this is what you were looking for, if not, let me know and I'll try again. |
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
July 30, 2026 05:17
78d2b13 to
cb38b2a
Compare
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
August 4, 2026 01:16
cb38b2a to
da132af
Compare
Fills in the TODO left when `CGSSetWindowBackgroundBlurRadius` moved behind `private-apple-apis`, so blur works again by default. The window's `contentView` is now a plain container `NSView` holding `WinitView`, and the effect view is installed as a sibling ordered below it, so the view returned by `raw-window-handle` is never unlinked from the window. With `private-apple-apis` enabled, the private API is used exactly as before. The material is tinted and follows the window's appearance, so the fixed radius of 80 is not reproduced; that stays available through the feature.
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
August 8, 2026 00:17
da132af to
83baa7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #4541 with the TODO filled in -
NSVisualEffectViewas the public default, your feature left alone for the radius.I tried to keep it simple, and answer @kchibisov's point about subviews, and follow the conventions I could see. The rest is in the changelog.
Let me know if you'd rather have it a different way. As before, happy to make changes.