UIKit: preserve queued GPU redraws while waiting - #4620
Open
brianconnoly wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_redrawcalls to queue redraws while the iOS event loop is waiting, polling, or already processing redrawsWaitUntildeadline after the GPU redraw queue drains, instead of leaving the repeating 0.1 microsecond timer hotThe transition is expressed through a small waker-action helper. The regression test
drained_gpu_queue_rearms_wait_until_deadlinecovers both the drained and still-queued paths.Validation
git diff --checkcargo +nightly fmt --check -p winit-uikitcargo test -p winit-uikit --target aarch64-apple-ios --no-run(compile-level validation; the target binary cannot execute on the host)488722b0