Fix "detailed results" button for doc-json benchmarks - #2532
Open
JonathanBrouwer wants to merge 1 commit into
Open
Fix "detailed results" button for doc-json benchmarks#2532JonathanBrouwer wants to merge 1 commit into
JonathanBrouwer wants to merge 1 commit into
Conversation
JonathanBrouwer
commented
Aug 14, 2026
| // We turn <benchmark>-<profile> into two separate parameters for the backend | ||
| const parts = benchmark.split("-"); | ||
| let parts: string[]; | ||
| if (benchmark.endsWith("-doc-json")) { |
Contributor
Author
There was a problem hiding this comment.
I'm not happy with this code, but not experienced enough in TS to know if there's a better way
Member
There was a problem hiding this comment.
It seems weird to use - on a string, but it's JavaScript, so I had to check what that does 😆 Probably a typo? The code doesn't seem to work though.
Member
There was a problem hiding this comment.
Maybe something like this? To keep it fully general:
[...a.slice(0, -"-doc-json".length).split("-"), "doc-json"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking "detailed results" on one of the doc-json benchmarks, for example in this run, returns an error:
r? @Kobzol