More refactoring + Implement step 1 of triage command - #2531
Merged
Conversation
JonathanBrouwer
force-pushed
the
triage-command2
branch
from
August 14, 2026 11:55
65ed0ec to
85a56d8
Compare
Kobzol
reviewed
Aug 14, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Thank you! Could you please also document the new command in the website, at https://perf.rust-lang.org/help.html?
|
|
||
| { | ||
| let conn = ctxt.conn().await; | ||
| record_try_benchmark_request_without_artifacts( |
Member
There was a problem hiding this comment.
Note (pre-existing): this is a bit sketchy, we record a request without artifacts, and then immediately attach the artifacts. We could just do it in one step for build. Though I suspect that would actually make the surrounding code more complicated, so it's not worth it.
Contributor
Author
There was a problem hiding this comment.
I can take a look in a follow-up PR if this is worth it, but I think indeed it would just make everything more complicated
JonathanBrouwer
force-pushed
the
triage-command2
branch
from
August 14, 2026 14:30
78ee9d3 to
086a1e9
Compare
Contributor
Author
|
@Kobzol I think I handled all the review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements step 1 of the triage command as described in the initial pitch #t-compiler/performance > Proposal for `@rust-timer triage` command @ 💬.
It consists of 4 commits, which I recommend to review individually:
enqueue_shaby pushing the comment posting logic out of the function & removing to option to provide multiple commits. This PR benefits from "hide whitespace" during review again.@rust-timer buildcommand into its own function, which can be re-used by the triage command.r? @Kobzol