fix: Parse inline asm with keyword as operand name - #23054
Merged
Conversation
We already have this problem for `format_args!()`, and I fixed it in rust-lang#21351 by something that was kinda a hack. Now that we face it the second time, I decided to take a more principled approach. We just remap the `SyntaxKind`, so everything after the parser sees a normal identifier. I'm a bit worried that some things might expect identifiers to always parse as such (e.g. assists), but we already have edition-dependent keywords (although unlike them, here picking the correct edition won't fix things) and contextual keywords (although they're the opposite: identifiers that are turned into keywords). In any case, if there is some problematic code we can fix it.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Aug 8, 2026
Member
There was a problem hiding this comment.
I think this is okay to do, given this is effectively contextual keywords / edition dependent keywords but the other way around. And assists technically need to special case these already (which most don't I think). That is to say this will break some right now but i think thats fine.
We should likely fix that at some point in our make-infra to always check names and namesrefs before being emitted and transform them to the raw syntax if necessary
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have this problem for
format_args!(), and I fixed it in #21351 by something that was kinda a hack. Now that we face it the second time, I decided to take a more principled approach. We just remap theSyntaxKind, so everything after the parser sees a normal identifier.I'm a bit worried that some things might expect identifiers to always parse as such (e.g. assists), but we already have edition-dependent keywords (although unlike them, here picking the correct edition won't fix things) and contextual keywords (although they're the opposite: identifiers that are turned into keywords). In any case, if there is some problematic code we can fix it.
Fixes #23052.