kore/rpc, cterm/symbolic, proof: client_label for per-claim RPC attribution - #4923
Closed
ehildenb wants to merge 1 commit into
Closed
kore/rpc, cterm/symbolic, proof: client_label for per-claim RPC attribution#4923ehildenb wants to merge 1 commit into
ehildenb wants to merge 1 commit into
Conversation
…bel for per-claim RPC attribution
Stamp a caller-defined label on every outgoing JSON-RPC request id
(`{client_label}-NNN`) so that booster's per-line `{request: ...}` context
in kore.jsonl can be attributed back to the originating claim/proof.
- kore/rpc.JsonRpcClient / KoreClient: accept client_label; expose set_client_label.
- cterm/symbolic.KoreClientServer: forward client_label to KoreClient.
- proof/{reachability,implies}: Prover.init_proof auto-stamps client.set_client_label(proof.id).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
(cherry picked from commit 87b1da7852efbdf5464cdcbd89e956aea1d281cb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stamp a caller-supplied label on every outgoing JSON-RPC request id (
{client_label}-NNN) so booster's per-line{request: ...}context inkore.jsonllogs map back to the originating claim. This allows syncing the log that pyk is producing for a given claim with the ones that Haskell backend is producing.Changes:
kore/rpc:JsonRpcClientandKoreClientaccept aclient_labelkwarg and exposeset_client_label().cterm/symbolic:KoreClientServerforwards the label to its client.proof/{reachability,implies}:Prover.init_proofauto-stamps the proof id asclient_label.Validation:
client_labelisstr(id(self)), so existing request-id shapes are preserved byte-for-byte for non-adopters.