x-wing: Reject non-contributory behaviour in X25519 component - #113
Open
str4d wants to merge 1 commit into
Open
Conversation
str4d
commented
Aug 4, 2026
|
|
||
| let sk = PrivateKey(arr.into()); | ||
| let sk = PrivateKey( | ||
| x_wing::DecapsulationKey::from(arr).reject_x25519_non_contributory_behaviour(), |
Contributor
Author
There was a problem hiding this comment.
I can make this configurable like I did in RustCrypto/KEMs#369 if you prefer for the next release.
Owner
|
Thank you! Ugh this will require a version bump oh well. I’d like to merge rn but I’d rather wait til it lands in upstream |
str4d
force-pushed
the
x-wing-reject-non-contributory-behaviour
branch
from
August 10, 2026 13:21
5ace3f7 to
aa3400c
Compare
Contributor
Author
|
Force-pushed to use updated RustCrypto/KEMs#369 API. I will try doing the same additive change here and see how unmaintainable it is. |
Owner
|
LGTM! I’ll wait for the x-wing PR to land first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9180 explicitly rejects it in DHKEM for X25519, so it is very likely that X-Wing as applied to HPKE will also require rejecting it. If the CFRG concrete-hybrid-kems document instead ends up requiring accepting it, then this crate would instead need to support it being configurable (as there are downstream users like age that require rejecting already).
Depends on RustCrypto/KEMs#369.