Repository navigation
fix: stop setup when saving SQLite configuration fails - #8
Open
ankushkhakale wants to merge 1 commit into
Open
ankushkhakale wants to merge 1 commit into
ankushkhakale wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
When SQLite rejects a configuration write,
setup.shcurrently reports success and continues with the build, leaving the app on its previous settings.This propagates the database failure and exits before the success messages, cache cleanup, build, or launch. It also adds a regression test using real SQLite and a short recovery note in the README.
The regression fails on the original script and passes with the fix. It checks that settings and the previous build cache survive the read-only failure, then verifies setup works after permissions are restored.
Before / After
Scenario: deliberately made the disposable database read-only (
chmod 444 data/geovista.db), then reranbash setup.shwith a different URL/port and declined launch. SQLite rejected writes; the baseline hid the error. Recorded excerpts:Before:
After:
Validation
npm testandnpm run test:coverage: 7 passed, no skips.Tested on Linux as a non-root user. The regression substitutes the build command; actual production build and startup behavior were checked separately.