Remove curl deprecated calls for PHP 8.4/8.5 - #359
Merged
rosell-dk merged 2 commits intoJun 18, 2026
Conversation
… 8.0 and the CI running on PHP 7.4 isn't too happy with it.
baldwinagency-pieter
force-pushed
the
remove-curl-deprecation-calls
branch
from
June 18, 2026 07:37
a8a34c5 to
50a44f7
Compare
Owner
|
Tested, merged and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some deprecated curl code lines:
CURLOPT_BINARYTRANSFERis no longer needed since PHP 5.5 according to the official docs or no longer needed since PHP 5.1.2 according to another source. It's also deprecated since PHP 8.4. Since this module requires at the minimum PHP 5.6, it should be fine to remove it.curl_closehas no effect since PHP 8.0 and was deprecated in PHP 8.5. So I'm wrapping it around a check to only call it when PHP is lower then 8.0@rosell-dk: since you've been active today, could you spare a few minutes to review and test these changes? And also to take a look at: #358?
We're going to upgrade one of our projects that uses this library to PHP 8.5 and we'd like to get rid of deprecation warnings.
Many thanks!