Skip to content

give more timeout budget for windows for each test graph discovery. - #396

Open
fujitatomoya wants to merge 1 commit into
rollingfrom
issues/395
Open

give more timeout budget for windows for each test graph discovery.#396
fujitatomoya wants to merge 1 commit into
rollingfrom
issues/395

Conversation

@fujitatomoya

Copy link
Copy Markdown

Description

closes #395

Fixes # (issue)

Is this user-facing behavior change?

yes, but this only extends the timeout for the tests.

Did you use Generative AI?

yes, claude fable 5.

Additional Information

Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas can you review this?

@mergify

mergify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fujitatomoya

Copy link
Copy Markdown
Author

Pulls: #396
Gist: https://gist.githubusercontent.com/fujitatomoya/2e85685841dc160f62a2ab74bea4f40b/raw/4e387196619d8810667b37107e05441f8d808a35/ros2.repos
BUILD args: --packages-above-and-dependencies sros2
TEST args: --packages-above sros2
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20052

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (51cedf6) to head (9d78c1f).

Additional details and impacted files
@@           Coverage Diff            @@
##           rolling     #396   +/-   ##
========================================
  Coverage    88.18%   88.18%           
========================================
  Files           18       18           
  Lines          601      601           
  Branches        53       53           
========================================
  Hits           530      530           
  Misses          52       52           
  Partials        19       19           
Flag Coverage Δ
unittests 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fujitatomoya
fujitatomoya requested a review from ahcorde August 11, 2026 01:55
@fujitatomoya fujitatomoya self-assigned this Aug 11, 2026
@fujitatomoya

fujitatomoya commented Aug 11, 2026

Copy link
Copy Markdown
Author

looks like this makes it more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 sros2 generate_policy tests consistently fail with rmw_zenoh_cpp on Windows

1 participant