NixOS: Make several Qt entries Qt5/6-independent - #53118
Merged
Merged
Conversation
On Ubuntu and RHEL, these entries refer to Qt5 or Qt6 depending on the underlying distribution. In Nix, we build all packages against the same distribution (nixos-unstable), so we have to make this distinction differently. We define the rosdep keys to resolve to package set qt5or6 and this package set is then defined in nix-ros-overlay as an alias of qt5 or qt6 depending on ROS distribution. This is similar approach to what we used previously for python3-qt-bindings.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
clalancette
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu and RHEL, these entries refer to Qt5 or Qt6 depending on the underlying distribution. In Nix, we build all packages against the same distribution (nixos-unstable), so we have to make this distinction differently. We define the rosdep keys to resolve to package set
qt5or6and this package set is then defined in nix-ros-overlay as an alias ofqt5orqt6depending on ROS distribution. Theqt5or6package set is introduced in lopsided98/nix-ros-overlay#905 and will be merged after this PR.This is similar approach to what we used previously for
python3-qt-bindings.