Skip to content

Correctly validate block tags in rocqchk demarshaller. #22408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppedrot wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Correctly validate block tags in rocqchk demarshaller. #22408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion checker/validate.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ let val_tag t mem ctx o =

let val_block mem ctx o =
if is_block mem o then
(if tag mem o > Obj.no_scan_tag then
let t = tag mem o in
(if not (Obj.first_non_constant_constructor_tag <= t && t <= Obj.last_non_constant_constructor_tag) then
fail mem ctx o "block: found no scan tag")
else fail mem ctx o "expected block obj"

Expand Down