Move print-mod-uid to main rocq exe instead of rocq repl - #22359
Open
SkySkimmer wants to merge 1 commit into
Open
Move print-mod-uid to main rocq exe instead of rocq repl#22359SkySkimmer wants to merge 1 commit into
SkySkimmer wants to merge 1 commit into
Conversation
SkySkimmer
added
needs: changelog entry
coqbot-app
Bot
removed
the
request: full CI
This avoids having to deal with random initializations, needing -q, and whatever else rocq repl involves. AFAICT -print-mod-uid is an internal flag used only by rocq makefile (for installing native files). rocq makefile does not support -native-output-dir AFAICT so we hardcode .coq-native.
SkySkimmer
added
request: full CI
SkySkimmer
force-pushed
the
printmoduid
branch
from
August 21, 2026 12:10
d3d687d to
c6011f7
Compare
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
marked this pull request as ready for review
August 21, 2026 12:10
ppedrot
reviewed
Aug 31, 2026
| md_deps : Obj.t; | ||
| md_ocaml : Obj.t; | ||
| md_info : Obj.t; | ||
| } [@@warning "-unused-field"] |
Member
There was a problem hiding this comment.
I think I'd rather have an abstract type and md_name defined as Obj.field, otherwise this adds some stronger coupling between this record and its official definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to deal with random initializations, needing -q, and whatever else rocq repl involves.
AFAICT -print-mod-uid is an internal flag used only by rocq makefile (for installing native files).
rocq makefile does not support -native-output-dir AFAICT so we hardcode .coq-native.