Fixing the logical kind of co/fixpoints in "Theorem with" (lost in #19259) - #19625
Merged
coqbot-app[bot] merged 1 commit intoOct 8, 2024
Conversation
coqbot-app
Bot
added
the
needs: full CI
Member
Author
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
SkySkimmer
approved these changes
Oct 2, 2024
Contributor
|
@herbelin something that wasn't done in the In the end, the overlays and the long time it took to get the initial refactoring merged was a factor as to keep them optional, but not an API choice per-se. |
Member
Author
You are here referring to your 2020 work, right? In any case, I have the same feeling. If you're ok we may e.g. think at how to group them. |
It was lost in 005ed23.
herbelin
force-pushed
the
master+amend-19259-theorem-with-fixpoint-merge
branch
from
October 2, 2024 14:32
9bcb2ab to
aeb6200
Compare
coqbot-app
Bot
added
the
needs: full CI
Contributor
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
Contributor
|
@coqbot merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was lost in #19259 (005ed23), even if probably observable only via
ppvernac.ml(e.g. with option beautify). However, #19029 will use it.