Skip to content

Fixes #7913: fixpoint with decreasing argument hidden behind a definition - #19296

Merged
coqbot-app[bot] merged 2 commits into
rocq-prover:masterfrom
herbelin:master+fixes7913-fixpoint-with-hidden-decreasing-arg
Sep 2, 2024
Merged

Fixes #7913: fixpoint with decreasing argument hidden behind a definition#19296
coqbot-app[bot] merged 2 commits into
rocq-prover:masterfrom
herbelin:master+fixes7913-fixpoint-with-hidden-decreasing-arg

Conversation

@herbelin

@herbelin herbelin commented Jun 30, 2024

Copy link
Copy Markdown
Member

Fixes / closes #7913 (made possible by #19091 and #19259).

  • Added / updated test-suite.
  • Added changelog.

@herbelin
herbelin requested review from a team as code owners June 30, 2024 09:46
@coqbot-app coqbot-app Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jun 30, 2024
@herbelin
herbelin marked this pull request as draft June 30, 2024 09:46
@herbelin herbelin added needs: fixing The proposed code change is broken. needs: merge of dependency This PR depends on another PR being merged first. labels Jun 30, 2024
@herbelin herbelin added this to the 8.21+rc1 milestone Jun 30, 2024
@herbelin herbelin added kind: fix This fixes a bug or incorrect documentation. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: fixpoints About Fixpoint, fix and mutual statements labels Jun 30, 2024
@herbelin herbelin added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: fixing The proposed code change is broken. needs: merge of dependency This PR depends on another PR being merged first. labels Jul 24, 2024
@herbelin
herbelin force-pushed the master+fixes7913-fixpoint-with-hidden-decreasing-arg branch from c666655 to 6f9a954 Compare July 24, 2024 12:54
@coqbot-app coqbot-app Bot removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. request: full CI Use this label when you want your next push to trigger a full CI. labels Jul 24, 2024
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 24, 2024
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 24, 2024
@herbelin
herbelin marked this pull request as ready for review July 24, 2024 12:58
@Blaisorblade

Copy link
Copy Markdown
Contributor

The original wish involves mutual inductives and recursion too. Can a test for that be added?

@Blaisorblade

Copy link
Copy Markdown
Contributor

And forgot to say, huge thanks @herbelin for working on this!!! Real quality of life improvement when these situations arise!

@herbelin
herbelin force-pushed the master+fixes7913-fixpoint-with-hidden-decreasing-arg branch from 6c9905d to 78d6151 Compare July 26, 2024 12:37
@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 26, 2024
@herbelin

Copy link
Copy Markdown
Member Author

Thanks for your feedback. Done!

@herbelin

Copy link
Copy Markdown
Member Author

@coqbot run full ci

@coqbot-app coqbot-app Bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 26, 2024
@SkySkimmer SkySkimmer self-assigned this Sep 2, 2024
@SkySkimmer

Copy link
Copy Markdown
Contributor

@coqbot merge now

@coqbot-app
coqbot-app Bot merged commit 035b56a into rocq-prover:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. kind: fix This fixes a bug or incorrect documentation. part: fixpoints About Fixpoint, fix and mutual statements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defining mutually recursive fixpoints as (definitional) type class instances

3 participants