Merge the execution paths for struct and measure/wf in Program Fixpoint - #19258
Merged
coqbot-app[bot] merged 6 commits intoJul 2, 2024
Merged
Conversation
herbelin
added
kind: cleanup
coqbot-app
Bot
added
the
needs: full CI
github-actions
Bot
added
the
needs: rebase
herbelin
added
request: full CI
herbelin
force-pushed
the
master+merge-fixpoint-struct-measure-wf
branch
from
June 27, 2024 08:37
7059fe8 to
e002c52
Compare
coqbot-app
Bot
removed
needs: rebase
herbelin
added
the
request: full CI
herbelin
force-pushed
the
master+merge-fixpoint-struct-measure-wf
branch
from
June 27, 2024 08:42
e002c52 to
38855f1
Compare
coqbot-app
Bot
removed
the
request: full CI
github-actions
Bot
added
the
needs: rebase
herbelin
force-pushed
the
master+merge-fixpoint-struct-measure-wf
branch
from
June 28, 2024 14:43
38855f1 to
63c9528
Compare
coqbot-app
Bot
added
needs: full CI
Member
Author
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
SkySkimmer
approved these changes
Jul 2, 2024
SkySkimmer
left a comment
SkySkimmer
left a comment
Contributor
There was a problem hiding this comment.
I didn't look closely but I approve of deleting comprogramfixpoint.ml
Contributor
|
@coqbot merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the seventh part of #18811.
The main commit is "Embed Program Fixpoint wf/measure in the main Co/Fixpoint routine." which moves the code for wf/measure from
comProgramFixpoint.mltocomFixpoint.ml(standardizing naming at this occasion), switching betweenbuild_program_fixpointandbuild_wellfoundeddepending on whetherstructormeasure/wfis used inProgram Fixpoint.There is also a technical commit "Prepare centralized interpretation of fixpoint annotation. " on merging in a central place
find_rec_annotthe interpretation of thestructormeasure/wfannotations.Finally, we prepare the code to support
measure/wfwithout theProgrammode.Depends on: