Skip to content

Better integration of Derive in declare.ml + fix of #18951 - #19092

Merged
coqbot-app[bot] merged 6 commits into
rocq-prover:masterfrom
herbelin:master+fix18951-anomaly-derive-admitted
Aug 27, 2024
Merged

Better integration of Derive in declare.ml + fix of #18951#19092
coqbot-app[bot] merged 6 commits into
rocq-prover:masterfrom
herbelin:master+fix18951-anomaly-derive-admitted

Conversation

@herbelin

@herbelin herbelin commented May 26, 2024

Copy link
Copy Markdown
Member

The PR better integrates Derive to declare.ml. It supports CInfo.t, Info.t and uses the declare_entry execution path. As a consequence, Derive now supports rather directly:

  • universe polymorphism
  • implicit arguments

By eventually exporting DefAttributes so that g_derive.mlg can use it, it could also support all standard attributes of definitions.

The PR relies on the support of Admitted for multiple statement goals in #19090 to support Admitted on Derive, thus also fixing #18951.

A full merge of the End_derive path in the End_regular path will be possible when:

Eventually, we can also imagine providing for free n-ary forms of Derive in the following style:

Derive f with g with h
  SuchThat T As H with U As I with V as J
  SuchThat W As K with X As L with Y as M.`

Fixes #18951

  • Added / updated test-suite.
  • Added changelog.
  • Add support for general declaration attributes

Depends on:

@herbelin herbelin added kind: fix This fixes a bug or incorrect documentation. kind: cleanup Code removal, deprecation, refactorings, etc. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. needs: merge of dependency This PR depends on another PR being merged first. part: derive request: full CI Use this label when you want your next push to trigger a full CI. labels May 26, 2024
@herbelin herbelin added this to the 8.20+rc1 milestone May 26, 2024
@herbelin
herbelin requested review from a team as code owners May 26, 2024 16:55
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 26, 2024
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label May 26, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from 506d67e to 01c7cfc Compare May 26, 2024 17:34
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 26, 2024
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label May 26, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from 01c7cfc to 9c84f76 Compare May 26, 2024 19:01
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 26, 2024
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label May 28, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from 9c84f76 to 26398e7 Compare May 28, 2024 19:02
@coqbot-app coqbot-app Bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels May 28, 2024
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label May 29, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from 34ee82a to ca0bae6 Compare July 2, 2024 13:09
@coqbot-app coqbot-app Bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 2, 2024
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 3, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from ca0bae6 to 35f333c Compare July 10, 2024 06:36
herbelin added a commit to herbelin/github-coq that referenced this pull request Jul 10, 2024
@coqbot-app coqbot-app Bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 10, 2024
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 21, 2024
@herbelin herbelin added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: merge of dependency This PR depends on another PR being merged first. labels Jul 23, 2024
herbelin added a commit to herbelin/github-coq that referenced this pull request Jul 23, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from 35f333c to fc7954d Compare July 23, 2024 07:34
@coqbot-app coqbot-app Bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jul 23, 2024
@coqbot-app

coqbot-app Bot commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

🔴 CI failure at commit fc7954d without any failure in the test-suite

✔️ Corresponding job for the base commit 43402d4 succeeded

❔ Ask me to try to extract a minimal test case that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following target: ci-rupicola
  • You can also pass me a specific list of targets to minimize as arguments.

@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 25, 2024
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 31, 2024
herbelin added a commit to herbelin/github-coq that referenced this pull request Jul 31, 2024
@herbelin
herbelin force-pushed the master+fix18951-anomaly-derive-admitted branch from fc7954d to 4dde3ad Compare July 31, 2024 11:26
@herbelin

Copy link
Copy Markdown
Member Author

CI happy.

Note that the test for #18951 will be in #19295.

@ppedrot ppedrot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@ppedrot

ppedrot commented Aug 3, 2024

Copy link
Copy Markdown
Member

@SkySkimmer if you have no additional comment on the current state, I can proceed to merge.

@ppedrot

ppedrot commented Aug 27, 2024

Copy link
Copy Markdown
Member

No answer from @SkySkimmer so @coqbot merge now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. kind: fix This fixes a bug or incorrect documentation. part: derive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anomaly "in Lemmas.save_lemma_admitted: more than one statement." with Derive

4 participants