Better integration of Derive in declare.ml + fix of #18951 - #19092
Merged
coqbot-app[bot] merged 6 commits intoAug 27, 2024
Merged
Conversation
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
May 26, 2024 17:34
506d67e to
01c7cfc
Compare
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
May 26, 2024 19:01
01c7cfc to
9c84f76
Compare
This was referenced May 27, 2024
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
May 28, 2024 19:02
9c84f76 to
26398e7
Compare
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
July 2, 2024 13:09
34ee82a to
ca0bae6
Compare
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
July 10, 2024 06:36
ca0bae6 to
35f333c
Compare
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 10, 2024
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 23, 2024
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
July 23, 2024 07:34
35f333c to
fc7954d
Compare
Contributor
|
🔴 CI failure at commit fc7954d without any failure in the test-suite ✔️ Corresponding job for the base commit 43402d4 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 31, 2024
herbelin
force-pushed
the
master+fix18951-anomaly-derive-admitted
branch
from
July 31, 2024 11:26
fc7954d to
4dde3ad
Compare
This includes: - supporting implicit arguments - supporting universe polymorphism - fixing rocq-prover#18951: Admitted for Derive
…omponents of Derive.
Member
Author
Member
|
@SkySkimmer if you have no additional comment on the current state, I can proceed to merge. |
Member
|
No answer from @SkySkimmer so @coqbot merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR better integrates
Derivetodeclare.ml. It supportsCInfo.t,Info.tand uses thedeclare_entryexecution path. As a consequence,Derivenow supports rather directly:By eventually exporting
DefAttributesso thatg_derive.mlgcan use it, it could also support all standard attributes of definitions.The PR relies on the support of
Admittedfor multiple statement goals in #19090 to supportAdmittedonDerive, thus also fixing #18951.A full merge of the
End_derivepath in theEnd_regularpath will be possible when:declare_possibly_mutual_definitionsinstead of inprepare_proofandclose_proofCInforather than inInfodeclare_possibly_mutual_definitionswill support dependent goals (asdeclare_possibly_mutual_parametersnow does)Eventually, we can also imagine providing for free n-ary forms of
Derivein the following style:Fixes #18951
Depends on:
[Subsumed] Add optional type annotation to Derive #19087 (to be able to do tests)