[obligations] Minor refactoring - #12371
Merged
Merged
Conversation
ejgallego
added
kind: cleanup
SkySkimmer
added
the
needs: rebase
SkySkimmer
reviewed
May 20, 2020
| let univs = UState.univ_entry ~poly:prg.prg_poly uctx in | ||
| let body = prg.prg_reduce body in | ||
| let ty = Option.map prg.prg_reduce ty in | ||
| let ty = Option.map prg.prg_reduce types in |
Contributor
There was a problem hiding this comment.
TBH I prefer typ to types as there's only 1
Also why don't we shadow here?
Contributor
Author
There was a problem hiding this comment.
Shadowing done, I used types as this is what has been used on the rest of Declare; maybe #12372 would be a good opportunity to discuss a better naming overall.
Not necessary anymore after the merge of obligation declaration into the main path.
SkySkimmer
reviewed
May 20, 2020
SkySkimmer
approved these changes
May 20, 2020
This removes a use of internal obligation data `prg_poly` and a couple of duplicate lines.
ejgallego
force-pushed
the
obligations+more_ref
branch
from
May 20, 2020 12:20
e1da431 to
e0dc8cb
Compare
coqbot
removed
the
needs: rebase
Contributor
Author
|
Failure is spurious, windows worker is full. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minors bits here and there, mostly self-explanatory.