Repository navigation
Fix handling of optional post-state - #33
Merged
Merged
Conversation
Contributor
Author
|
@Rot127 ping. |
Rot127
approved these changes
Aug 22, 2026
Member
|
Please fix the build job. |
moste00
force-pushed
the
fix/handle_missing_poststate
branch
from
August 22, 2026 17:42
86b4542 to
b89bbb5
Compare
moste00
force-pushed
the
fix/handle_missing_poststate
branch
from
August 25, 2026 22:15
b89bbb5 to
3ea18af
Compare
Contributor
Author
|
All green @Rot127 |
Rot127
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The piqi format of the trace files allows a frame to contain no post-state, either with a completely absent list or with a list that is empty (i.e., a
Nullable<List<...>>that has two absent states,nulland[].)This PR introduces tolerance for those kinds frames so as to not pollute the stats with spurious
misexecutedcounts, there are now 2 new categories for a frame:PostStateLessmeans a frame was found to not have a post state at all, andPostStateEmptymeans the frame has a post state that has no operands.NOTE: the only producer, BAP QEMU, seems to almost never produce a truly
PostStateLessframe, since it always initializes an empty post state list when it starts a frame, butPostStateLesswas introdued nonetheless for completeness and format-faithfulness.This goes well with this PR BinaryAnalysisPlatform/qemu#47.