Skip to content

fix minor compilation error due to Rizin refactor - #32

Closed
moste00 wants to merge 0 commit into
rizinorg:masterfrom
moste00:fix/vm_ctx_error
Closed

moste00 wants to merge 0 commit into
rizinorg:masterfrom
moste00:fix/vm_ctx_error

Conversation

@moste00

@moste00 moste00 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

A clean master branch of rz-tracetest fails compilation against a clean dev branch of rizin, appears to be a refactor of VM code that neglected updating rz-tracetest.

@Rot127

Rot127 commented Jul 27, 2026

Copy link
Copy Markdown
Member

I think you can check out #30 to fix the CI.

@moste00

moste00 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@wargio @Rot127 This looks stalled on the nix failure, I already have a PR to @b1llow 's repo to fix up the hashes but let me know if I can do something else to speed this up.

@moste00

moste00 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

@Rot127 Looks like it's blocked on the nix change and billow is not responding, can we force-merge here despite the nix failure ?

@wargio

wargio commented Aug 16, 2026

Copy link
Copy Markdown
Member

i think we can merge and fix later the nix test

@moste00

moste00 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

i think we can merge and fix later the nix test

@Rot127 WDYT ?

@Rot127

Rot127 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Please rebase and we can merge.

@moste00 moste00 closed this Aug 25, 2026
@moste00

moste00 commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor Author

@Rot127 No need, the sole line changed was subsumed into the newly merged billow's PR, a rebase naturally made the diff null and that closed the PR automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants