Repository navigation
Conversation
Adds the TransactionProposal entry, LoanBroker.DomainID, and MPToken.RecoveryKey. ripple/se/supported now uses the wire codes of ContractHash, ContractCode, ContractAccount, and Function, so the merge keeps the escrow fields (ProposalID, RecoveryKey, SigningFor, ProposedTransaction) and drops the contract ones.
![ripple-code-reviewer[bot]](https://avatars.githubusercontent.com/u/3165523?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a mechanical regeneration of ledger objects and sfields from rippled's current schema. The sfield renames (ContractHash→ProposalID, ContractCode→RecoveryKey, ContractAccount→SigningFor, Function→ProposedTransaction) preserve the same wire codes and value types, the new TransactionProposal object follows the existing generated-object pattern consistently, and the LoanBroker/MPToken additions and Vault doc comment update are straightforward and self-consistent. No correctness, security, or wiring issues found in the added code.
There was a problem hiding this comment.
🟢 Approval recommended
The regenerated bindings are consistent with existing generation patterns and include appropriate exports and tests.
0 open findings
What changed in this PR
Regenerates XRPL ledger-object bindings and SFields from current rippled definitions.
Changes:
- Adds typed
TransactionProposalaccessors and exports. - Adds
LoanBroker::domain_id()andMPToken::recovery_key(). - Replaces four conflicting contract SFields with authoritative definitions.
| File | Description |
|---|---|
xrpl-common-stdlib/src/sfield.rs |
Updates conflicting SField definitions. |
xrpl-common-stdlib/src/objects/mod.rs |
Exports transaction proposal APIs. |
xrpl-common-stdlib/src/objects/generated/vault.rs |
Updates share issuance documentation. |
xrpl-common-stdlib/src/objects/generated/transaction_proposal.rs |
Adds typed transaction proposal bindings and tests. |
xrpl-common-stdlib/src/objects/generated/mptoken.rs |
Adds recovery-key accessors and coverage. |
xrpl-common-stdlib/src/objects/generated/mod.rs |
Registers and re-exports the new generated module. |
xrpl-common-stdlib/src/objects/generated/loan_broker.rs |
Adds domain-ID accessors and coverage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
High Level Overview of Change
Reruns
generate-ledger-objects.shandgenerate-sfields.shagainst current rippled. This adds theTransactionProposalledger entry,LoanBroker.domain_id(), andMPToken.recovery_key(), and updates theVault.share_mpt_id()doc comment from the dev portal.Context of Change
ripple/se/supportedaddedProposalID,RecoveryKey,SigningFor, andProposedTransactionat the wire codes thatxrplf/smart-contractsuses forContractHash,ContractCode,ContractAccount, andFunction. The sfield merge keeps the escrow fields, so those four contract constants are removed. Nothing in this repo uses them.RecoveryKeywas needed for the regeneratedmptoken.rsto compile. The newTransactionProposaltypes are added to theobjectsre-export list.Type of Change
Test Plan
./scripts/generate-ledger-objects.sh --checkpasses./scripts/fmt.shand./scripts/clippy.shpass./scripts/build-and-test.sh: 593 tests pass, 0 fail🤖 Generated with Claude Code