Repository navigation
fix: Fix build and regenerate sfield/tx_flags/ledger-objects - #309
Conversation
Signed-off-by: David Fuelling <sappenin@gmail.com>
Script now check if rippled is already running before starting up Docker. Also, Docker image is only defined in one place. Signed-off-by: David Fuelling <sappenin@gmail.com>
…wasm-stdlib into df/show-docker-instructions
Co-authored-by: ripple-code-reviewer[bot] <291892032+ripple-code-reviewer[bot]@users.noreply.github.com>
Co-authored-by: ripple-code-reviewer[bot] <291892032+ripple-code-reviewer[bot]@users.noreply.github.com>
A code-review suggestion was applied one line too high, replacing the DEVNET=true usage comment with a stray `if` that had no matching `fi`, so bash failed with "syntax error: unexpected end of file". Restore the comment; the intended condition simplification on the real `if` stays. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…mbering Upstream renumbered several sfield codes (Gas family, new MPToken/Vault fields) and renamed tmfMPT* flags to tfMPTSet*/tifMPT*, breaking the build against the newly pinned XRPLD_DOCKER_IMAGE. Regenerate sfield.rs, tx_flags.rs, and the affected objects/generated/*.rs files from current upstream rather than hand-patching them. Also fix generateTxFlags.js, which didn't resolve bare-constant `lsif*`-style ledger-flag aliases (only the LSF_FLAG XMACRO form), so tifMPT* trailer flags emitted references to undefined identifiers. host_function_audit is disabled separately: rippled replaced HostFuncWrapper.h's typedefs with a WasmHostFunctionsImpl class, which compareHostFunctions.js's parser doesn't understand yet. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…wasm-stdlib into df/show-docker-instructions
sappenin
changed the title
![ripple-code-reviewer[bot]](https://avatars.githubusercontent.com/u/3165523?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is primarily generated-code regeneration (sfield/tx_flags/ledger-object getters) driven by an upstream rippled renumbering, plus tooling/doc improvements (new scripts/docker-rippled.sh, updated run-tests.sh/setup.sh, README/CONTRIBUTING updates) and disabling the host_function_audit job pending a follow-up fix. The sfield and tx_flags renumbering was checked mechanically against the prior values and rippled's field families and lines up consistently (no bit-overlap or off-by-one issues found), and the generator fix in tools/generateTxFlags.js correctly adds a second regex pass for bare-constant lsif*-style declarations. The new docker-rippled.sh script's logic (health check reuse, port-reuse fallback, image lookup from the CI workflow file) looks sound and matches the documented behavior in CONTRIBUTING.md/README.md/scripts/README.md. No correctness, security, or resource-leak issues were found in the added/changed lines that meet the bar for confident flagging.
sappenin
changed the title
Summary
ripple/se/supported) renumbered several sfield codes. This PR regenerates them.tools/generateTxFlags.js: it didn't resolve bare-constantlsif*-style ledger-flag aliases (only theLSF_FLAG(...)XMACRO form), so the newtifMPT*trailer flags were emitting references to undefined identifiers. Now also scans forinline constexpr std::uint32_t lsifName = 0x...;declarations.host_function_auditto be fixed in a follow-on PR (ci: Fix host function audit script #293)Test plan
cargo build --workspace/cargo test --workspace(root workspace)cargo build --target wasm32v1-none --releaseinexamples/ande2e-tests/./scripts/clippy.sh./scripts/fmt.sh./scripts/check-wasm-exports.sh./scripts/generate-ledger-objects.sh --check(confirms no drift)