Skip to content

feat: Remove float_root - #283

Merged
mvadari merged 2 commits into
mainfrom
remove-float-root
Sep 4, 2026
Merged

mvadari merged 2 commits into
mainfrom
remove-float-root

Conversation

@mvadari

@mvadari mvadari commented Aug 25, 2026 •

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Title says it all

Context of Change

From XRPLF/rippled#8110

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@ripple-code-reviewer ripple-code-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, consistent removal of the float_root host function across all binding layers (empty/test/wasm/trait), its Number::root wrapper and test, and the e2e test usage. All deletions line up—no leftover references to float_root remain in the diff, and no new code was introduced that warrants flagging.

@sappenin

sappenin commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

@mvadari I'm OK to merge this despite the two failing checks.

  1. check_ledger_objects_generated is failing due to divergences in rippled branches (not sure it should block this).
  2. host_function_audit check will be fixed with ci: Fix host function audit script #293. We can push that one first, or this one; low conviction from my side.

@mvadari
mvadari merged commit 1ef442a into main Sep 4, 2026
17 of 19 checks passed
@mvadari
mvadari deleted the remove-float-root branch September 4, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants