Repository navigation
feat: Remove float_root - #283
Merged
Merged
Conversation
sappenin
approved these changes
Aug 25, 2026
There was a problem hiding this comment.
Clean, consistent removal of the float_root host function across all binding layers (empty/test/wasm/trait), its Number::root wrapper and test, and the e2e test usage. All deletions line up—no leftover references to float_root remain in the diff, and no new code was introduced that warrants flagging.
Collaborator
|
@mvadari I'm OK to merge this despite the two failing checks.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all
Context of Change
From XRPLF/rippled#8110
Type of Change