Skip to content

fix: only treat a radix node that holds a value as a duplicate (closes #36) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhuici merged 2 commits into from
Sep 1, 2026
Merged

fix: only treat a radix node that holds a value as a duplicate (closes #36) #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ced33e
Only treat a radix node that holds a value as a duplicate key (closes…
Dani-giron Aug 19, 2026
43e8b24
Merge branch 'apotheosis2' into n1-radix-ghost-duplicate
danielhuici Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/controllers/apotheosis.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,11 @@ where
pub fn insert(&mut self, item: R) -> bool {
let radix_key = item.search_id().to_radix_key();

// A radix node can exist without holding a value: splitting the tree on a
// shared prefix creates internal nodes whose `data` is None. Only a node
// that actually holds an index is a real duplicate.
if let Some(ref key) = radix_key
&& self.radix.find(key).is_some()
&& self.radix.find(key).is_some_and(|node| node.data.is_some())
{
tracing::warn!("Key already exists in radix tree: {:?}", key);
return false;
Expand Down
Loading