Repository navigation
fix: read through the facade in the test suite (closes #30) - #31
Merged
danielhuici merged 2 commits intoSep 1, 2026
Merged
Conversation
Author
|
Merge order note for the current batch of open PRs. #34, #35, #37 were branched from this PR's branch ( I looked into retargeting their base branch to this one to make GitHub enforce the order, but that only works when the base branch exists in this repo; Recommended order: this one (#31) first. |
danielhuici
added a commit
to Dani-giron/APOTHEOSIS
that referenced
this pull request
Sep 1, 2026
The documentation was written in July and reviewed against the code of that moment. Meanwhile reverseame#24 (distance type in the dump/load header), reverseame#25 (GEXF export extracted to export::gexf, gexf fork emits the attribute schema), reverseame#27 (record constructors return Result) and reverseame#31 (facade read accessors) landed. Update the interface document, the three views, the glossary and the README accordingly. Text only; the C&C component model and diagrams are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
apotheosis2branch does not compile: the test suite added in #21 accessesApotheosis::hnswandApotheosis::records, which #14 made private.The root cause is that #14 was only partially implemented. Its Expected behavior specified
draw_model(),len()andis_empty()on the facade; only the last two were added, so the tests had no facade method to read the graph structure through and reached into the private field instead.Changes
src/controllers/apotheosis.rs: adds the missingdraw_model(), delegating toHnsw::draw_model(). It adds no state and no new invariant: it exposes for reading the same datadraw()already writes out as GEXF..hnsw.draw_model()becomes.draw_model()(13 sites) and.records.len()becomes the existing.len()(18 sites), acrossconfig_boundary.rs,config_matrix.rs,fitness_functions.rs,ann_correctness.rsandapi_contract.rs. No test logic changed, only how each test reaches the data.Test plan
Verified locally with the same commands CI runs:
cargo clippy --all-targets --all-features -- -D warningsclean,cargo fmt --checkclean, and all 44 tests passing.Closes #30.