Skip to content

fix(ci): retry playwright:install-deps on transient apt mirror failures #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santgr11 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ci): retry playwright:install-deps on transient apt mirror failures #5726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0315c37
fix(ci): retry playwright:install-deps on transient apt mirror failures
santgr11 Jul 24, 2026
ef66a17
Merge branch 'main' into fix/e2e-install-deps-retry
santgr11 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions .github/workflows/ui_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,17 @@ jobs:
- name: Install Playwright system dependencies
if: steps.playwright-cache.outputs.cache-hit == 'true' # <-- Re-enable condition
working-directory: ./apps/laboratory/
run: pnpm playwright:install-deps
run: |
for attempt in 1 2 3; do
echo "playwright:install-deps attempt $attempt/3"
if pnpm playwright:install-deps; then
Comment on lines +303 to +306

@0xmkh 0xmkh Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to do this before, but then realised retries can actually bypass certain bugs.

Would it be possible to retry on test level rather than on playwright level?

@santgr11 santgr11 Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This retry is for the dep install, not the tests themselves. If this step fails, then there is no test to run

exit 0
fi
echo "Attempt $attempt failed (likely a transient apt mirror timeout) - retrying in 15s..."
sleep 15
done
echo "playwright:install-deps failed after 3 attempts"
exit 1

- name: Install Playwright Browsers
if: steps.playwright-cache.outputs.cache-hit != 'true' # <-- Re-enable condition
Expand Down Expand Up @@ -429,7 +439,17 @@ jobs:
- name: Install Playwright system dependencies
if: steps.playwright-cache.outputs.cache-hit == 'true' # <-- Re-enable condition
working-directory: ./apps/laboratory/
run: pnpm playwright:install-deps
run: |
for attempt in 1 2 3; do
echo "playwright:install-deps attempt $attempt/3"
if pnpm playwright:install-deps; then
exit 0
fi
echo "Attempt $attempt failed (likely a transient apt mirror timeout) - retrying in 15s..."
sleep 15
done
echo "playwright:install-deps failed after 3 attempts"
exit 1

- name: Download all shard blob reports
uses: actions/download-artifact@v4
Expand Down
Loading