Skip to content

fix(common): parse numeric string EVM chain IDs #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daixihegu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(common): parse numeric string EVM chain IDs #5692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-plums-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@reown/appkit-common': patch
---

Support numeric string inputs in `NetworkUtil.parseEvmChainId`.
8 changes: 6 additions & 2 deletions packages/common/src/utils/NetworkUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ export const NetworkUtil = {
},

parseEvmChainId(chainId: string | number) {
return typeof chainId === 'string'
if (typeof chainId === 'number') {
return chainId
}

return chainId.includes(':')
? this.caipNetworkIdToNumber(chainId as CaipNetworkId)
: chainId
: Number(chainId)
},

getNetworksByNamespace(networks: CaipNetwork[] | undefined, namespace: ChainNamespace) {
Expand Down
5 changes: 5 additions & 0 deletions packages/common/tests/NetworkUtil.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ describe('NetworkUtil', () => {
expect(NetworkUtil.parseEvmChainId('eip155:42')).toBe(42)
})

test('parses numeric string chain ID', () => {
expect(NetworkUtil.parseEvmChainId('1')).toBe(1)
expect(NetworkUtil.parseEvmChainId('42')).toBe(42)
})

test('returns number input as-is', () => {
expect(NetworkUtil.parseEvmChainId(1)).toBe(1)
expect(NetworkUtil.parseEvmChainId(42)).toBe(42)
Expand Down
Loading