Conversation
…dcoded shape
Why:
- The app rendered "CFA60,000" where French convention writes "60 000 FCFA". In
French the comma is the decimal separator, so a French reader saw that string
and read sixty. Four defects came from the same hand-written template: the XOF
symbol token, a hardcoded prefix, no gap before the symbol, and a grouping
comma pinned through toLocaleString('en-US'). The factory default separator was
never derived from the device either, so the app displayed one convention and
expected input in another.
What:
- A single profile table carries the four rules per convention, and adds the
French one: space grouping, comma decimal, suffixed symbol. The parser derives
its separators from that same table so the two cannot drift, and learns the
three grouping spaces on a branch that returns before the decimal tie-break,
so a space can never be read as a decimal point. The profile is derived from
the device locale on first launch only; a stored choice always wins, and an
install predating the field keeps the static default rather than being
restyled by an update. Intl was rejected: its output depends on the host ICU,
it renders XOF as "F CFA", and it cannot honour the user's separator setting.
…y-formatting fix(currency): format amounts by locale convention instead of one har…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.