Conversation
Why: - The SDK forwards console output as breadcrumbs by default, with the raw argument list attached. The app logs an instalment amount and a wallet balance when a recurring rule is skipped, per-wallet drift on import, a category name at seed time, and validation messages that interpolate the rejected value. All of it was reaching Sentry. What: - A named guard drops every console-category breadcrumb before it enters the scope, which also covers native crashes since native sync patches the same scope method. It is a blanket drop, not a content filter: deciding which log line carries money is a losing game, and the guard has to protect the logs nobody has written yet. Other categories pass through by reference. Values still reach the device system log, which no Sentry-side guard can address.
…rumbs fix(sentry): stop console output from becoming breadcrumbs
Why: - The SDK attached two persistent identifiers that no option can disable: the installation id on every event, and an iOS device hash derived from identifierForVendor that survives reinstall as long as any other app from the same vendor remains. Neither was declared, and neither helps debug a crash. Network breadcrumbs and release-health sessions carried the same identifier for metrics this project does not use. What: - A beforeSend guard strips the user object, the device hash and the root flag, written defensively because an exception there would be swallowed and the event would ship unstripped. XHR breadcrumbs are disabled through the resolver form so the rest of the default integration set is preserved by reference rather than re-enumerated. Session tracking is off. Culture context and touch breadcrumbs are deliberately kept: five locales and timezone-sensitive recurring dates make them diagnostic, and touch carries component names only. Crash grouping is unaffected; "users affected" and crash-free-users are not.
…ng-undeclared-data fix(sentry): stop sending persistent identifiers and network breadcrumbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.