Conversation
Why: - The settings switch asked for permission and stored a preference that nothing read, so it promised reminders it could never deliver. Meanwhile a budget app is only opened when the user remembers it, and closed-testing activity had gone quiet - the reminder is the retention mechanism the app was missing. What: - One repeating daily notification at 18:00 device local time, scheduled through a single function behind a stable identifier so relaunching cannot stack duplicates. It fires unconditionally: a normal day holds several expenses, so "already recorded something" does not mean "done for today", and the app does not guess. A foreground handler stops it being swallowed, an Android channel gives it heads-up importance, and a revoked OS permission now reverts the switch instead of leaving it reading "on" while nothing fires.
…nder feat(notifications): add a daily spending reminder
Why: - Selection was signalled by a soft shadow over two near-identical backgrounds: 1.06:1 contrast in the light theme, 1.27:1 in dark. There was effectively nothing to see, and nothing at all for a screen reader, since no accessibility helper in the codebase could emit accessibilityState. What: - The selected segment now takes the accent fill the rest of the app already uses for selection, reaching 9.12:1 and 4.54:1. The sliding indicator is gone: it never rendered under test, so selected state had never been asserted anywhere. State now lives on each button, which makes it announceable and testable, and removed the only left-to-right assumptions in the control.
…lity fix(ui): give the segment control a visible selected state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.